Re: [RFC BlueZ 6/6] gas: Move all the code to only one file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinicius,

On Fri, Jan 25, 2013, Vinicius Costa Gomes wrote:
> Our Generic Attribute/Access Service plugin is small and simple enough
> to be kept in only one file.
> ---
>  Makefile.plugins        |  4 +--
>  profiles/gatt/gas.c     | 46 ++++++++++++++++++++++++++++
>  profiles/gatt/main.c    | 47 -----------------------------
>  profiles/gatt/manager.c | 79 -------------------------------------------------
>  profiles/gatt/manager.h | 24 ---------------
>  5 files changed, 47 insertions(+), 153 deletions(-)
>  delete mode 100644 profiles/gatt/main.c
>  delete mode 100644 profiles/gatt/manager.c
>  delete mode 100644 profiles/gatt/manager.h
> 
> diff --git a/Makefile.plugins b/Makefile.plugins
> index faab011..f497782 100644
> --- a/Makefile.plugins
> +++ b/Makefile.plugins
> @@ -69,9 +69,7 @@ builtin_sources += profiles/health/mcap_lib.h profiles/health/mcap_internal.h \
>  endif
>  
>  builtin_modules += gatt
> -builtin_sources += profiles/gatt/main.c profiles/gatt/manager.h \
> -			profiles/gatt/manager.c profiles/gatt/gas.h \
> -			profiles/gatt/gas.c
> +builtin_sources += profiles/gatt/gas.c

You seem to have forgotten to remove gas.h in this patch. You remove it
from Makefile.plugins but it's still in the tree and gas.c includes it.
You'll also want to make gas_register/unregister static together with
removing the header file.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux