On Thu, Jan 17, 2013 at 06:09:32AM -0800, Marcel Holtmann wrote: Hi Marcel, > I do not like this enhanced magic. How is this suppose to work? And it > is also not explained in the commit message. Or used in this patch. sco_options_enhanced is not definitive, this patch is meant to describe different parameters for the socket option that could be selected based on the mode field. To ensure compatibility accross versions, the size of the socket options structure can be checked. The idea is to read supported codecs list using mgmt API. Then,it is possible to select some codecs and the enhanced accept/setup sync conn are sent. It does not make sense to get this option since the codec is negociated externally. If this mode is removed, we fallback on version 1 of RFC (except at this time, sco_options.mode was sco_options.codec). And it is it is easy to add new modes to select latency, or packet types without breaking existing API. Thanks, Frédéric -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
