Hi Marcel, On Tue, Jan 8, 2013 at 3:10 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > can we make this a bit more generic with a bit more details on what you > are testing. > > Also having a separate test case for str8, str16 and also str32 of > course would be a good idea. Same for url8, url16 and url32. In addition > checking empty strings and really long strings is a good idea. > Especially long strings that match the max len size. This was supposed to be a set of initial tests, specially to validate the fix I sent on the other patch. I was going to improve the test coverage as I read more of the code. But I can work on a set of tests which cover all reachable cases for sdp_extract_attr() (I want to focus on this function for now because it is less used than others and could hide other bugs.) and send them at once, including corner cases. > What I actually like to see is that we can specific element sequences in > raw and also what they are suppose to match. So we need to ensure that > we also extract the right string value and types. And not just the size. The "match" data could be raw bytes which I get by converting the returned sdp_data_t to PDU format using sdp_gen_pdu(). What do you think? Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
