Hi Marcel, On Mon, Jan 7, 2013 at 11:25 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: >> #define SDP_IS_UUID(x) ((x) == SDP_UUID16 || (x) == SDP_UUID32 || (x) ==SDP_UUID128) >> #define SDP_IS_SEQ(x) ((x) == SDP_SEQ8 || (x) == SDP_SEQ16 || (x) == SDP_SEQ32) >> +#define SDP_IS_TEXT_STR(x) ((x) == SDP_TEXT_STR8 || (x) == SDP_TEXT_STR16 || \ >> + (x) == SDP_TEXT_STR32) > > can someone please explain to me why we are extending the library. I > thought I made it clear that it is mostly end of life and we are not > adding new features. However some people keep adding stuff. This macro was added simply to be used for the next patches which simplify/refactor core code. The fact the header is public API was not the main reason to add it here. Unless you suggest adding new stuff to another, internal-only header? If so, please provide some example how to extend SDP library code that is used by internal BlueZ code. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html