Re: [PATCH BlueZ 3/6] gdbus: Introduce GDBusInterfaceFlags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Sun, Dec 23, 2012 at 6:09 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
>> The flags should be passed in g_dbus_register_interface_with_flags,
>> currently there only one flag which is G_DBUS_INTERFACE_FLAG_EXPERIMENTAL
>> which works similarly to G_DBUS_METHOD_FLAG_EXPERIMENTAL but for the
>> whole interface.
>> ---
>>  gdbus/gdbus.h  | 13 +++++++++++++
>>  gdbus/object.c | 20 ++++++++++++++++++++
>>  2 files changed, 33 insertions(+)
>
> can we not just check if the interface contains any non experimental
> method, signals and properties and base that decision around that?

It can work, but we would have to iterate on every single item, so in
terms of code is quite a bit more complex so I favored adding a new
function even though we might replace it in the long run.

> I am not really in favor of introducing a version with flags.

The final solution I was thinking is passing another interface
containing the table as this tend to be quite static e.g.:

struct GDBusInteface {
  const char *name;
  GDBusInterfaceFlags flags;
  const GDBusMethodTable *methods;
  const GDBusSignalTable *signals;
  const GDBusPropertiesTable *properties;
};

Obviously this would break g_dbus_register_interface and generate
quite a bit more changes to the daemon code.


--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux