Hi, On Fri, Dec 14, 2012 at 12:18 PM, Santiago Carot <sancane@xxxxxxxxx> wrote: > Hi, > > 2012/12/14 Johan Hedberg <johan.hedberg@xxxxxxxxx>: >> Hi Luiz, >> >> On Fri, Dec 14, 2012, Luiz Augusto von Dentz wrote: >>> --- >>> doc/network-api.txt | 4 ++-- >>> profiles/network/connection.c | 2 +- >>> profiles/network/server.c | 2 +- >>> 3 files changed, 4 insertions(+), 4 deletions(-) >> >> All patches in this set have been applied. Thanks. >> > > just a few comments, Wouldn't it have been better to add an > API_VERSION macro and stick it besides each interface?, I haven't gone > deept through each patch but it just looks like you are only adding > the version number to each interface. In the future it could be > annoying to have to go through all the source code to increment just > the version number. Each interface is independent, so if you break lets say org.bluez.Network1 API you just change it not everything. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
