Hi Szymon,
On Wed, Dec 05, 2012, Szymon Janc wrote:
> plain char may be treated as signed or unsigned depending on compiler
> (as oposite to other integer types). Use signed char explicitly when
> signed type is needed.
>
> This fix following compilation error on ARM:
>
> CC src/bluetoothd-adapter.o
> src/adapter.c: In function ‘convert_entry’:
> src/adapter.c:2710:2: error: comparison is always true due to limited
> range of data type [-Werror=type-limits]
> cc1: all warnings being treated as errors
> make[1]: *** [src/bluetoothd-adapter.o] Error 1
> ---
> src/adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 3c5d277..0cbce78 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -2673,7 +2673,7 @@ static void convert_ltk_entry(GKeyFile *key_file, void *value)
> static void convert_entry(char *key, char *value, void *user_data)
> {
> struct device_converter *converter = user_data;
> - char device_type = -1;
> + signed char device_type = -1;
> char filename[PATH_MAX + 1];
> GKeyFile *key_file;
> char *data;
Couldn't we just initialize the value to BDADDR_BREDR or maybe use an
int for it. And the naming is confusing as the value contains an address
type and not a device type.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
