From: Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> Instead of defining _GNU_SOURCE in each source file (and potentially forgetting in some), tell the build system we use extensions and let it define _GNU_SOURCE in config.h. --- After seeing several build fixes due to missing definition of _GNU_SOURCE, I decided to respin a previous patch sent by Anderson Lizardo (http://comments.gmane.org/gmane.linux.bluez.kernel/28954). This is used in several other projects like kmod, pulseaudio, systemd and others. Worrying autoconf breaks things is not worth IMO, otherwise we should not trust autoconf to create the config.h. AC_USE_SYSTEM_EXTENSIONS only defines _GNU_SOURCE and others in config.h when required. configure.ac | 1 + monitor/btsnoop.c | 1 - monitor/sdp.c | 1 - profiles/input/hog_device.c | 1 - src/adapter.c | 1 - src/mgmt.c | 1 - src/sdp-xml.c | 1 - src/textfile.c | 1 - tools/btsnoop.c | 1 - tools/ciptool.c | 1 - tools/hciattach.c | 1 - tools/rfcomm.c | 1 - 12 files changed, 1 insertion(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index c97d403..48e2817 100644 --- a/configure.ac +++ b/configure.ac @@ -3,6 +3,7 @@ AC_INIT(bluez, 5.x) AM_INIT_AUTOMAKE([foreign subdir-objects color-tests]) AM_CONFIG_HEADER(config.h) +AC_USE_SYSTEM_EXTENSIONS m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) diff --git a/monitor/btsnoop.c b/monitor/btsnoop.c index 9f4e5f3..04a6dff 100644 --- a/monitor/btsnoop.c +++ b/monitor/btsnoop.c @@ -26,7 +26,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <fcntl.h> diff --git a/monitor/sdp.c b/monitor/sdp.c index 5812098..45ee59b 100644 --- a/monitor/sdp.c +++ b/monitor/sdp.c @@ -26,7 +26,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <stdlib.h> #include <string.h> diff --git a/profiles/input/hog_device.c b/profiles/input/hog_device.c index 8fdc3c6..a873eac 100644 --- a/profiles/input/hog_device.c +++ b/profiles/input/hog_device.c @@ -27,7 +27,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdlib.h> #include <stdbool.h> #include <errno.h> diff --git a/src/adapter.c b/src/adapter.c index 3c67f8a..ae229b0 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -26,7 +26,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <unistd.h> diff --git a/src/mgmt.c b/src/mgmt.c index 4196bdd..2dc8a16 100644 --- a/src/mgmt.c +++ b/src/mgmt.c @@ -26,7 +26,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <unistd.h> diff --git a/src/sdp-xml.c b/src/sdp-xml.c index 32eeaea..7d5f626 100644 --- a/src/sdp-xml.c +++ b/src/sdp-xml.c @@ -25,7 +25,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <ctype.h> diff --git a/src/textfile.c b/src/textfile.c index 9d88fbc..b6a7e1f 100644 --- a/src/textfile.c +++ b/src/textfile.c @@ -25,7 +25,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <ctype.h> diff --git a/tools/btsnoop.c b/tools/btsnoop.c index 0a01adf..dcb4a26 100644 --- a/tools/btsnoop.c +++ b/tools/btsnoop.c @@ -26,7 +26,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <fcntl.h> diff --git a/tools/ciptool.c b/tools/ciptool.c index edce9da..e240f38 100644 --- a/tools/ciptool.c +++ b/tools/ciptool.c @@ -25,7 +25,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <stdlib.h> diff --git a/tools/hciattach.c b/tools/hciattach.c index 09aed24..e1e80af 100644 --- a/tools/hciattach.c +++ b/tools/hciattach.c @@ -27,7 +27,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <fcntl.h> diff --git a/tools/rfcomm.c b/tools/rfcomm.c index e8bdd0f..affdbc7 100644 --- a/tools/rfcomm.c +++ b/tools/rfcomm.c @@ -25,7 +25,6 @@ #include <config.h> #endif -#define _GNU_SOURCE #include <stdio.h> #include <errno.h> #include <fcntl.h> -- 1.8.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
