Re: [PATCH BlueZ 1/3] gdbus: Don't register DBus.Properties with no properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

On Thu, Nov 29, 2012 at 3:33 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Thu, Nov 29, 2012 at 3:19 PM, Lucas De Marchi
> <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> Delay registering DBus.Properties interface until the moment there are
>> properties on that path. This is needed for objects that currently don't
>> expose any property to not export the interface.
>> ---
>>  gdbus/object.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/gdbus/object.c b/gdbus/object.c
>> index 3101ca6..47116bd 100644
>> --- a/gdbus/object.c
>> +++ b/gdbus/object.c
>> @@ -1213,9 +1213,6 @@ static struct generic_data *object_path_ref(DBusConnection *connection,
>>                                         manager_methods, manager_signals,
>>                                         NULL, data, NULL);
>>
>> -       add_interface(data, DBUS_INTERFACE_PROPERTIES, properties_methods,
>> -                                       properties_signals, NULL, data, NULL);
>> -
>>         return data;
>>  }
>>
>> @@ -1336,6 +1333,12 @@ gboolean g_dbus_register_interface(DBusConnection *connection,
>>                 return FALSE;
>>         }
>>
>> +       if (properties != NULL && !find_interface(data->interfaces,
>> +                                               DBUS_INTERFACE_PROPERTIES))
>> +               add_interface(data, DBUS_INTERFACE_PROPERTIES,
>> +                               properties_methods, properties_signals, NULL,
>> +                               data, NULL);
>> +
>>         add_interface(data, name, methods, signals, properties, user_data,
>>                                                                 destroy);
>>
>> --
>> 1.8.0.1
>
> Ack

Patches pushed to BlueZ and obexd. Thanks.


--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux