Hi Marcel,
----- Original Message -----
From: "Marcel Holtmann" <marcel@xxxxxxxxxxxx>
To: "Syam Sidhardhan" <s.syam@xxxxxxxxxxx>
Cc: <linux-bluetooth@xxxxxxxxxxxxxxx>
Sent: Tuesday, October 23, 2012 8:14 PM
Subject: Re: [PATCH 2/5] Bluetooth: Remove unnecessary include export.h
Hi Syam,
For files only using THIS_MODULE and/or EXPORT_SYMBOL, map
them onto including export.h -- or if the file isn't even
using those, then just delete the include.
have you actually check this on other architectures like PowerPC or
Sparc?
I have checked it only for Arm and i686 arch. I do not have other
environment to check.
If any one has other architectures environment ready, kindly do the build
and ack for it. Apart from
build, I have cross checked the code once gain to make sure that nothing
breaks.
commit 8c520a59927a5600973782505dbb750d985057c4
Author: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
Date: Wed May 23 04:04:22 2012 -0300
Bluetooth: Remove unnecessary headers include
Most of the include were unnecessary or already included by some other
header.
Replace module.h by export.h where possible.
Padovan, In the above commit, you have explicitly added the
export.h in that commit. Did you face any error or warning
while building with out export.h?
Commit Reference:
http://git.kernel.org/?p=linux/kernel/git/bluetooth/bluetooth-next.git;a=commitdiff;h=8c520a59927a5600973782505dbb750d985057c4#patch11
Thanks,
Syam
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
