Hi Mikel, On Thu, Oct 25, 2012, Mikel Astiz wrote: > >> > + req = g_new0(struct connect_req, 1); > >> > + req->device = dev; > >> > >> Isn't btd_device_ref() required here? > > > > Looks like you're right and I missed this in my initial review. I went > > ahead and pushed an extra patch to fix this. > > I don't think this patch was needed. Actually, the device pointer in > struct connect_req can be completely removed, since the callback > already receives such pointer, and the network_peer takes care of the > device refcounting. Mea culpa for adding this unnecessary field. Good point. Feel free to send a patch to remove it. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
