Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi -

On Thu, 25 Oct 2012, Andrei Emeltchenko wrote:

Hi,

On Wed, Oct 24, 2012 at 06:55:34PM -0700, Marcel Holtmann wrote:
Hi Fengguang,

Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---
 net/bluetooth/l2cap_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next.orig/net/bluetooth/l2cap_core.c	2012-10-25 08:23:52.456742699 +0800
+++ linux-next/net/bluetooth/l2cap_core.c	2012-10-25 08:23:55.056742760 +0800
@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
 	l2cap_ertm_send(chan);
 }

-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)

I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight
or we need that later on to be actually public.

Agree with Marcel here. This shall be public.

Yes, it does need to be public. Andrei will need to call it from the AMP physical link code, but I'm not sure exactly where (HCI event handling or somewhere in amp.c or a2mp.c).

--
Mat Martineau

Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux