Hi Marcel, On Tue, Oct 23, 2012 at 3:02 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Johan, > >> This patch makes sure that settings which are specific for BR/EDR >> capable adapters are not allowed for non-BR/EDR (e.g. LE-only) adapters. >> Instead, a "not supported" error is returned of such a setting is >> attempted to be set for a non-BR/EDR adapter. >> >> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx> >> --- >> net/bluetooth/mgmt.c | 22 +++++++++++++++++++--- >> 1 file changed, 19 insertions(+), 3 deletions(-) > > can we lead with this patch. It seems to be useful no matter what we do > for LE peripheral or single-mode controllers. I agree that current upstream will be more consistent if these settings are made "not supported" for LE (as they indeed are not implemented yet). I was just confused that the same patch series that improve LE peripheral support does not include properly support for Connectable/Discoverable modes on this role (which may restrict the usefulness?). Johan: do you have further plans on improving LE peripheral support after these patches? If yes, please keep in mind that we still have ongoing plans to push broadcaster/observer roles upstream, which also requires hability to enable/disable advertising and set advertising data/parameters. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
