On Wednesday 17 of October 2012 11:48:36 Luiz Augusto von Dentz wrote: > Hi Szymon, Hi Luiz, > >> We should probably get rid of the free_lock as well. > > > > Well, this is what this patch does, doesn't it?:) > > What about the attached patch, it should fix the references for good > by using the dc_timer when the reference drops to 0, I just need to > check if 1 second is enough to cover all cases including the ones > where the remote device connects but doesn't setup any stream, with > the devices I have 1 second seems enough. Yeap, this fix crash I've observed. However, avdtp_get_internal() now returns newly created session with ref=0 and in avdtp_confirm_cb() there is unref called when btd_request_authorization failed. Due to ref being signed int (why?) this could lead to not-nice-to-debug bug if that session is reclaimed before dc timer fires (ref would go from -1 to 0). Also I'm having trouble with tracking lifetime of session object.. I think only avdtp_ref/unref function should really care about ref count. That would require other function to only use ref/unref to get/free session object. e.g. avdtp_free should be only called from disconnect_timeout() and connection_lost() should only trigger other session users to drop their references. Same goes to set_disconnect_timer() which should only be called from avdtp_unref. There should be no need to call connection_lost from disconnect_timeout as this timer should only run when there is no references held to that session, right? Or do I miss something?:) -- BR Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
