Hi Marcel, On Sat, Oct 13, 2012 at 01:53:25AM +0200, Marcel Holtmann wrote: > Hi Andrei, > > > When assigning amp_mgr in hci_conn (type AMP_LINK) get also reference. > > In hci_conn_del those references would be put for both types. > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > --- > > net/bluetooth/amp.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> > > > diff --git a/net/bluetooth/amp.c b/net/bluetooth/amp.c > > index 59da0f1..e525e23 100644 > > --- a/net/bluetooth/amp.c > > +++ b/net/bluetooth/amp.c > > @@ -123,9 +123,11 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr, > > hcon->attempt++; > > hcon->handle = __next_handle(mgr); > > hcon->remote_id = remote_id; > > - hcon->amp_mgr = mgr; > > hcon->out = out; > > > > + hcon->amp_mgr = mgr; > > + amp_mgr_get(mgr); > > + > > We could discuss that amp_mgt_get(mgr) should just return mgr and you > can write this like this: > > hcon->amp_mgr = amp_mgr_get(mgr); Good idea. I will make it in the following patches. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
