Hi Andrei, On Thu, Oct 11, 2012, Andrei Emeltchenko wrote: > > @@ -230,7 +232,7 @@ static void build_pairing_cmd(struct l2cap_conn *conn, > > req->max_key_size = SMP_MAX_ENC_KEY_SIZE; > > req->init_key_dist = 0; > > req->resp_key_dist = dist_keys; > > - req->auth_req = authreq; > > + req->auth_req = (authreq & AUTH_REQ_MASK); > > return; > > } > > > > @@ -239,7 +241,7 @@ static void build_pairing_cmd(struct l2cap_conn *conn, > > rsp->max_key_size = SMP_MAX_ENC_KEY_SIZE; > > rsp->init_key_dist = 0; > > rsp->resp_key_dist = req->resp_key_dist & dist_keys; > > - rsp->auth_req = authreq; > > + rsp->auth_req = (authreq & AUTH_REQ_MASK); > > Would it be better to omit braces like in the line above? For both cases. I actually didn't notice the line above the second chunk. I always thought it was good practice to have explicit braces around bitwise operations to avoid evaluation-order bugs (particularly in if-statements) so I just always do it. I'll leave this to Gustavo or Marcel to object to if necessary (otoh Marcel already gave his ack). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
