Hi Johan, On Thu, Oct 04, 2012 at 03:17:02PM +0300, Johan Hedberg wrote: > Hi Andrei, > > On Thu, Oct 04, 2012, Andrei Emeltchenko wrote: > > hdev might be NULL, so we need to avoid possible NULL derefernce in > > handler->func functions. > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > --- > > net/bluetooth/mgmt.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > Nack. Some of the handlers actually should be getting a NULL hdev and > there's code higher up in the function you're changing that ensures that > NULL is allowed for those handlers but not for any others (which should > safely be able to skip NULL checks). True, BTW: this would be nice to put this explanation as comment there. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
