Re: [PATCH] storage: Move adapter info to adapter.conf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frédéric,

On Wed, Oct 3, 2012 at 10:26 AM, Frédéric Danis
<frederic.danis@xxxxxxxxxxxxxxx> wrote:
> +int keyfile_put_string(const char *pathname, const char *group,
> +                               const char *key, const char *value);
> +int keyfile_put_boolean(const char *pathname, const char *group,
> +                               const char *key, gboolean value);
> +int keyfile_put_integer(const char *pathname, const char *group,
> +                               const char *key, int value);
> +
> +char *keyfile_get_string(const char *pathname, const char *group,
> +                               const char *key);

One suggestion (which may or may not be acked by core devs), what
about being consistent here and use:

int keyfile_get_string(const char *pathname, const char *group, const
char *key, char **value);

(i.e. use return value for error and value pointer on last parameter).

> +int keyfile_get_boolean(const char *pathname, const char *group,
> +                               const char *key, gboolean *value);
> +int keyfile_get_integer(const char *pathname, const char *group,
> +                               const char *key, int *value);
> +
> +int keyfile_del(const char *pathname, const char *group, const char *key);
> +
> +typedef void (*keyfile_key_cb) (char *key, char *value, void *data);
> +typedef void (*keyfile_group_cb) (char *group, void *data);
> +
> +int keyfile_foreach_key(const char *pathname, const char *group,
> +                               keyfile_key_cb func, void *data);
> +int keyfile_foreach_group(const char *pathname,
> +                               keyfile_group_cb func, void *data);
> +
> +#endif /* __KEYFILE_H */

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux