Hi Srinivasa, On Mon, Oct 1, 2012 at 10:14 AM, Venkateswaran, Srinivasa Ragavan <srinivasa.ragavan.venkateswaran@xxxxxxxxx> wrote: > On Mon, Oct 1, 2012 at 12:33 PM, > <srinivasa.ragavan.venkateswaran@xxxxxxxxx> wrote: >> From: Srinivasa Ragavan <srinivasa.ragavan.venkateswaran@xxxxxxxxx> >> >> --- >> client/map.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++- >> client/transfer.c | 3 +- >> doc/client-api.txt | 11 +++++ >> 3 files changed, 127 insertions(+), 2 deletions(-) > > Ignore this patch, this has a partial patch I was trying from Luiz. > Sorry for the mess, sent an updated one. > > -Srini. I just merged some fix last week so you would have to rebase your changes, but I got some suggestions: 1. Use properties, so for setting delete/read the application should use SetProperty method and it can get the values with GetProperties and PropertyChanged to signal when the values has changed. (Note this may change if we add support to standard D-Bus Properties interface but the idea is the same just the interface change) 2. What is this filler byte and lseek for? 3. We probably need to add support for non-body/apparam only PUT so we can pass NULL to filename. (maybe this is the reason for 2?) -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
