Hi Johan: On Thu, Sep 27, 2012 at 4:43 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi, > > On Tue, Sep 25, 2012, João Paulo Rechi Vita wrote: >> +int mgmt_start_scanning(int index) > > Firstly I don't think the name is good since BR/EDR also has the concept > of scanning (page scan & inquiry scan). Secondly, maybe it'd be simpler > to reuse mgmt_start_discovery and simply add a new parameter which > provides the value for info->discov_type? > > Johan My suggestions are: 1. rename to mgmt_start_le_scanning 2. add a new parameter to mgmt_start_discovery: gboolean le_only 3. add a new parameter to mgmt_start_discovery: informing the adapter operation mode(BREDR/LE/BREDR_LE) Option 3 will require to expose controller info/settings to adapter.c. It is necessary to know the controller features to send the right discover type. btd_adapter_start function could be extended to receive the supported features or a parameter specifying the operation mode. IMO, using this approach we are duplicating information. Which approach do you prefer? Regards, Claudio. -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
