Hi Chen,
On Mon, Sep 24, 2012, chen.ganir@xxxxxx wrote:
> +BlueZ D-Bus Battery API description
> +****************************************
Please keep the "underline" consistent with the length of the text above
it.
> + Texas Instruments, Inc. <chen.ganir@xxxxxx>
What's this supposed to be? If you want a copyright statement here then
make it of the proper format. Author info is not needed as we have the
AUTHORS file and the commit history.
> +Device Battery hierarchy
> +=====================================
Same thing with the consistency of the "underline"
> +Service org.bluez
> +Interface org.bluez.Battery
> +Object path [variable prefix]/{hci0,..}/dev_XX_XX_XX_XX_XX_XX/BATTYYYY
> +YYYY is numeric value between 0 and 9999.
I don't think you need a separate comment for the "YYY". We don't have
that for the "XX" stuff either.
> + array{object} Batteries [readonly]
I guess you should mark this with [experimental] since it'll be removed
with the advent of ObjectManager.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
