Hi Andrzej, On Tue, Sep 25, 2012, Andrzej Kaczmarek wrote: > + Measurement: > + > + int16 Exponent: > + int32 Mantissa: > + > + Measurement value is calculated as > + (Mantissa) x (10^Exponent) > + > + In case of invalid or missing data, > + Exponent is set to 0 and Mantissa is > + set to 2^23-1 (0x7FFFFF hexadecimal). Why aren't we using the D-Bus DOUBLE type for this? For invalid/missing data just leave out these values from the dict. No need to try to brute-force a 1:1 mapping from the protocol to D-Bus. > + > + string Unit: > + > + Possible values: "Celsius" or "Fahrenheit" String properties should be lower-case. Please fix (both doc and implementation). > + string Type (optional): > + > + Only present if measurement type is known. > + > + Possible values: "Armpit", "Body", "Ear", > + "Finger", "Intestines", "Mouth", > + "Rectum", "Toe", "Tympanum" Same here. > + string Measurement: > + > + Possible values: "Final" or "Intermediate" And here. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
