Re: [PATCH v2 2/6] audio: Fix crash on gateway close

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikel,

On Tue, Sep 25, 2012 at 5:55 PM, Mikel Astiz <mikel.astiz.oss@xxxxxxxxx> wrote:
> From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx>
>
> gateway_close() can be called multiple times and thus the code must
> handle the case where device->gateway is already NULL.
>
> This issue can be easily reproduced if a device is removed (unpaired)
> while HFP gateway is connected.
> ---
>  audio/gateway.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/audio/gateway.c b/audio/gateway.c
> index 45b25a1..93a70ba 100644
> --- a/audio/gateway.c
> +++ b/audio/gateway.c
> @@ -566,6 +566,9 @@ int gateway_close(struct audio_device *device)
>         struct gateway *gw = device->gateway;
>         int sock;
>
> +       if (gw == NULL)
> +               return 0;
> +
>         if (gw->rfcomm) {
>                 sock = g_io_channel_unix_get_fd(gw->rfcomm);
>                 shutdown(sock, SHUT_RDWR);
> --
> 1.7.11.4

There is something wrong if this is being called multiple times, so we
need to find the root cause of this happening and fix there.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux