Re: [PATCH] Cycling Speed and Cadence profile (CSCP) API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

On Fri, Sep 21, 2012 at 5:09 AM, Andrzej Kaczmarek
<andrzej.kaczmarek@xxxxxxxxx> wrote:
> +Cycling Speed and Cadence API description
> +****************************************
> +
> +Copyright (C) 2012     Tieto Poland
> +
> +Cycling Manager hierarchy
> +============================
> +
> +Service                org.bluez
> +Interface      org.bluez.CyclingManager

I don't have much to comment on the API as I haven't had time to read
the CSCP spec yet, but about the name prefix, what about
"CyclingSpeed" (and "RunningSpeed" for the future RSCP) ? Too long?

The "Cycling" name is slightly uncommon, but still not that bad IMHO.

> +Properties     String Location (optional) [readwrite]

String -> string

> +                               uint16 LastWheelEventTime (optional):
> +
> +                                       Value of Last Wheel Event time

Better specify that this is in "1/1024 second units" (just checked on
developer.bluetooth.org).

> +
> +                               uint16 CrankRevolutions (optional):
> +
> +                                       Cumulative number of crank revolutions
> +
> +                               uint16 LastCrankEventTime (optional):
> +
> +                                       Value of Last Crank Event time

Same here.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux