Re: [PATCH v3 09/10] battery: Add support for notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chen,

On Thu, Sep 20, 2012 at 4:27 AM,  <chen.ganir@xxxxxx> wrote:
> @@ -140,6 +156,18 @@ static void process_batteryservice_char(struct characteristic *ch)
>         }
>  }
>
> +static void batterylevel_enable_notify_cb(guint8 status, const guint8 *pdu,
> +                                               guint16 len, gpointer user_data)
> +{
> +       struct characteristic *ch = (struct characteristic *)user_data;

Casting above seems unnecessary (gpointer is typedef to void*).

> +
> +       if (status != 0) {
> +               error("Could not enable batt level notification.");
> +               ch->canNotify = FALSE;

This camelCase is inconsistent with other struct fields on the same file.

> +               process_batteryservice_char(ch);
> +       }
> +}
> +
>  static gint device_battery_cmp(gconstpointer a, gconstpointer b)
>  {
>         const struct characteristic *ch = a;

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux