Re: [PATCHv5 02/17] Bluetooth: A2MP: Create amp_mgr global list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Tue, Sep 18, 2012 at 09:43:51AM +0200, Marcel Holtmann wrote:
> Hi Andrei,
> 
> > Create amp_mgr_list global list which will be used by different
> > hci devices to find amp_mgr.
> > 
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> > ---
> >  include/net/bluetooth/a2mp.h |    8 ++++++++
> >  net/bluetooth/a2mp.c         |   29 +++++++++++++++++++++++++++++
> >  2 files changed, 37 insertions(+)
> > 
> > diff --git a/include/net/bluetooth/a2mp.h b/include/net/bluetooth/a2mp.h
> > index 6a76e0a..e56d656 100644
> > --- a/include/net/bluetooth/a2mp.h
> > +++ b/include/net/bluetooth/a2mp.h
> > @@ -20,11 +20,15 @@
> >  #define A2MP_FEAT_EXT	0x8000
> >  
> >  struct amp_mgr {
> > +	struct list_head	list;
> >  	struct l2cap_conn	*l2cap_conn;
> >  	struct l2cap_chan	*a2mp_chan;
> >  	struct kref		kref;
> >  	__u8			ident;
> >  	__u8			handle;
> > +	enum {
> > +		READ_LOC_AMP_INFO,
> > +	} state;
> 
> I am not a huge fan of these things. Wouldn't it be better to define the
> states externally properly.

Yes, this might be done.

Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux