From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> Acquiring a transport is needed in two different situations: either we are initiating the audio stream locally, or the remote side initiated it and thus we are just reacting. In the second case, we would expect the stream is already available, and otherwise the operation should fail. This means the media API needs to be extended in order to make this difference. This issue is specially relevant in the case of SCO, because the current approach is racy. With HFP, for example (say BlueZ has the HS role), the following race condition could be met: 1. Phone has an incoming call and thus starts in-band ringing. 2. SCO connection is accepted and stablished by BlueZ. 3. Gateway interface state is changed to Playing. 4. Exactly afterwards, the user routes the audio to the phone, to have a private conversation. So the SCO link is closed. 5. In parallel, PulseAudio sees the transition to Playing, and acquires the transport. 6. BlueZ receives an Acquire() request, but SCO is down. So it tries to reconnect the SCO link. The last step is an undesired behavior (the audio is routed back to the car). BlueZ should be smart enough to know that the SCO connection shouldn't be reestablished, but this is only possible if the endpoint provides additional information in the media API. Note that the API change introduced by this patch is backward compatible, meaning that older versions of BlueZ will just ignore the flag. So clients are encouraged to use it without necessarily adding a dependency to newer versions of BlueZ. --- audio/transport.c | 4 ++++ doc/media-api.txt | 11 +++++++++++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/audio/transport.c b/audio/transport.c index 4653cc7..cc9c56f 100644 --- a/audio/transport.c +++ b/audio/transport.c @@ -807,6 +807,10 @@ static DBusMessage *acquire(DBusConnection *conn, DBusMessage *msg, if (lock == 0) return btd_error_invalid_args(msg); + if (transport->state != TRANSPORT_STATE_PENDING && + g_strstr_len(accesstype, -1, "?") != NULL) + return btd_error_failed(msg, "Transport not playing"); + if (media_transport_acquire(transport, lock) == FALSE) return btd_error_not_authorized(msg); diff --git a/doc/media-api.txt b/doc/media-api.txt index da8ef53..b9802d9 100644 --- a/doc/media-api.txt +++ b/doc/media-api.txt @@ -282,6 +282,17 @@ Methods dict GetProperties() "rw": Read and write access + The accesstype string can also be combined with a "?" + suffix, which will make the request optional. This + typically means the transport will only be acquired if + it is already available (remote-initiated), but + otherwise no request will be sent to the remote side. + In this last case the function will fail. Note that, + due to compatibility issues with older versions of + BlueZ, clients are encouraged to use exactly the same + accesstype for Release(), matching the string provided + to Acquire(). + void Release(string accesstype) Releases file descriptor. -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
