Hi Mat, On Mon, Sep 10, 2012 at 04:49:36PM -0700, Mat Martineau wrote: > > Andrei - > > On Tue, 4 Sep 2012, Andrei Emeltchenko wrote: > > >From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > > >For AMP we always assume EFS L2CAP option. > > > >Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > >--- > >include/net/bluetooth/l2cap.h | 2 ++ > >net/bluetooth/l2cap_core.c | 7 ++++++- > >2 files changed, 8 insertions(+), 1 deletion(-) > > > >diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > >index 161be83..3ec8679 100644 > >--- a/include/net/bluetooth/l2cap.h > >+++ b/include/net/bluetooth/l2cap.h > >@@ -508,6 +508,8 @@ struct l2cap_chan { > > __u32 remote_acc_lat; > > __u32 remote_flush_to; > > > >+ __u8 ctrl_id; > >+ > > How about "remote_amp_id" instead of ctrl_id? The channel move code > tracks local_amp_id. > Why does the remote controller id need to be > tracked? I think you are right, I think it shall be local AMP controller id. So we can keep this name ctrl_id for local one or do you think local_amp_id is better? Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html