Hi Johan, nitpicks On Wed, Sep 05, 2012 at 11:14:10AM +0300, Johan Hedberg wrote: ... > + conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &ev->bdaddr); > + if (!conn) > + return; > + > + switch (ev->type) { > + case HCI_KEYPRESS_STARTED: > + conn->passkey_entered = 0; > + return; > + case HCI_KEYPRESS_ENTERED: > + conn->passkey_entered++; > + break; > + case HCI_KEYPRESS_ERASED: > + conn->passkey_entered--; > + break; > + case HCI_KEYPRESS_CLEARED: > + conn->passkey_entered = 0; > + break; Can we use the same style for switch like below: ... > + case HCI_EV_USER_PASSKEY_NOTIFY: > + hci_user_passkey_notify_evt(hdev, skb); > + break; > + > + case HCI_EV_KEYPRESS_NOTIFY: > + hci_keypress_notify_evt(hdev, skb); > + break; > + > case HCI_EV_SIMPLE_PAIR_COMPLETE: > hci_simple_pair_complete_evt(hdev, skb); > break; Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html