Re: [PATCH] Bluetooth: Use GFP_KERNEL in read_index_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 03 of September 2012 14:49:59 Szymon Janc wrote:
> On Monday 03 of September 2012 15:34:11 Andrei Emeltchenko wrote:
> > Hi all,
> 
> Hi Andrei,
> 
> > 
> > On Fri, Aug 31, 2012 at 10:54:58AM -0700, Gustavo Padovan wrote:
> > > Hi Szymon,
> > > 
> > > * Szymon Janc <szymon.janc@xxxxxxxxx> [2012-08-31 09:05:46 +0200]:
> > > 
> > > > read_index_list is executed by user thread running in kernel-mode
> > > > thus is allowed to sleep.
> > > > 
> > > > Signed-off-by: Szymon Janc <szymon.janc@xxxxxxxxx>
> > > > ---
> > > >  net/bluetooth/mgmt.c |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > Patch has been applied to bluetooth-next. Thanks.
> > 
> > Was this tested? Gustavo please remove this patch from the tree untill
> > this issue is fixed.
> 
> read_index_list() is only called from mgmt_control() (via mgmt_handlers[]).
> mgmt_control (as well as other mgmt_handlers) allocate memory with
> GFP_KERNEL flag.
> 
> I'm not sure why do you get this warning...

Ahhh, rwlock is held while doing memory allocation..
Yes, this should be reverted.

-- 
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux