Hi Andrzej, On Fri, Aug 31, 2012 at 8:48 AM, Andrzej Kaczmarek <andrzej.kaczmarek@xxxxxxxxx> wrote: > Hi, > > Here are few patches to cleanup proximity profile code a bit which seem to > keep track of some data which are redundant and has minor issue with device > driver registration. > > Most cleanup is done in patch #3 which removes tracking of DBusConnection > across whole plugin and simply uses get_dbus_connection() wherever necessary. > This is different than other profile plugins do, but reduces code size and > memory footprint a bit so can be done for other plugins as well if accepted. While some cleanups here are very welcome, I'm worried that you are cleaning up things before finishing the Proximity Reporter implementation. Power Level characteristic for instance is currently a stub, how do you plan to store it per adapter, without the struct reporter_adapter? Therefore I suggest you split the "trivial" cleanups from the removal of struct reporter_adapter. BTW, do you have plans to add more features to the Proximity Reporter implementation? Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
