Hi, On Tue, Aug 28, 2012 at 2:37 PM, Venkateswaran, Srinivasa Ragavan <srinivasa.ragavan.venkateswaran@xxxxxxxxx> wrote: > Hi, > > I was testing MAP and I came across a crash (trace attached). I > figured out that the crash is because dbus expects gboolean to be 0/1 > where as it holds the 'int' results from strcasecmp. I've attached the > patch that fixed the problem for me. This is my first message/patch to > this list, sorry if it isn't in the right/expected format, just > suggest me and I could put it right. Interesting that I did not run into this bug before, can you do a some changes to the commit message: 1. Add a prefix to the first line of the commit e.g: client: Fix crash on map module 2. Add a description what you are fixing e.g. you can use the backtrace and state this is caused by line _dbus_return_val_if_fail (*bool_p == 0 || *bool_p == 1, FALSE); 3. How about using your intel email? After you are done with that you can send us the patch with git format-email + git send-email -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html