Hi Rafal, On Tue, Aug 28, 2012, Garbat Rafal wrote: > >>I'm wondering if it wouldn't make more sense to have these > >>RegisterWatcher APIs (thermometer, heart rate, others?) per-adapter > >>instead of per-device. That would be much friendlier to applications in > >>that they wouldn't need to separately search for paired/configured > >>devices supporting a specific service. Moving this to be per-adapter > >>would also mean that the first parameter of the Watcher methods would be > >>the object path of which device is in question. > >So any comments on this? I'd like to get this moving forward and finally > >merged upstream. > > Sorry for a late reply. > I guess that moving RegisterWatcher methods to the adapter iface > sounds reasonable, but we need to think how to do it i.e. to > properly handle devices that support several profiles based on > registering watchers (do we want to register watcher for all the > profiles or have a parameter for Watcher methods to specify the > target), etc. > Correct me if I'm wrong or missing something. > I'd suggest merging heartrate as this profile is quite similar to > the thermometer and it works (and no one have any objections to the > code) and re-factor this later on. > Unfortunately I'll be off for the next three weeks, but I can get > back to this when I'm back. Since it's not just a refactoring but an API change/break I'd rather get this right from the start. The thermometer API should also be updated to be per-adapter for our next release (BlueZ 5). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
