Re: [PATCH obexd v0] client-doc: Guarantee prefix in transfer paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Patrick,

On Tue, Aug 21, 2012 at 11:31 AM, Patrick Ohly <patrick.ohly@xxxxxxxxx> wrote:
>> diff --git a/doc/client-api.txt b/doc/client-api.txt
>> index 839a78c..7ca65cc 100644
>> --- a/doc/client-api.txt
>> +++ b/doc/client-api.txt
>> @@ -466,7 +466,7 @@ Transfer hierarchy
>>
>>  Service              org.bluez.obex.client
>>  Interface    org.bluez.obex.Transfer
>> -Object path  [variable prefix]/{transfer0,transfer1,...}
>> +Object path  [variable prefix]/{session0,session1,...}/{transfer0,...}
>>
>>  Methods              dict GetProperties()
>
> It would be even better to explicitly mention that the "[variable
> prefix]" here is the same as the "[variable prefix]" in the Session.
>
> Or perhaps change it like this?
>
> -Object path    [variable prefix]/{transfer0,transfer1,...}
> +Object path    [session prefix]/{transfer0,...}

Hmm, I prefer the original proposal since that imo looks more clear
how the path is formatted, anyway the point here is that the transfers
are tied to sessions.

> Using this knowledge efficiently is not always possible, however. D-Bus
> itself has a "path_namespace" filter [1], but many D-Bus bindings don't
> expose it (Python [2], GIO D-Bus [3]). Therefore a client using those
> bindings still has to receive all Transfer signals and do its own
> filtering.
>
> [1] http://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-routing-match-rules
> [2] http://dbus.freedesktop.org/doc/dbus-python/api/dbus.connection.Connection-class.html#add_signal_receiver
> [3] http://developer.gnome.org/gio/stable/GDBusConnection.html#g-dbus-connection-signal-subscribe

Apparently people are not doing a good job with bindings then, arg
matching is quite essential to things like NameOwnerChanged, anyway
for what is worth even properties have this race condition with values
changing in meantime while GetAll/Get/GetProperties is returning, so
it seems we need to solve this problem by making the transfer
properties unlikely to change so the application have enough time to
subscribe to signals.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux