Hi Johan, On Fri, Aug 17, 2012 at 5:29 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Claudio, > > On Thu, Aug 16, 2012, Claudio Takahasi wrote: >> This patch series adds a new GATT based plugin for GAP and GATT service. >> The objective is cleanup: moving some GATT related operations from the >> device(core) to a GATT based plugin. >> >> This first part is related to GAP appearance characteristic. A second >> patch will be sent soon to manage Service Changed and GATT/ATT MTU. >> >> Claudio Takahasi (10): >> gatt: Add Generic Access/Attribute Profile plugin >> gatt: Add GAP/GATT device registration >> gatt: Add read Appearance characteristic >> gatt: Add storing Appearance >> core: Remove Appearance characteristic read >> gatt: Emit PropertyChanged for Appearance >> core: PropertyChanged signal for Icon/class >> core: PropertyChanged signal for Icon/Appearance >> gatt: Map Appearance value 0x0000 to "unknown" >> gatt: Don't store Appearance if value is "unknown" >> >> Makefile.am | 8 ++- >> profiles/gatt/gas.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++ >> profiles/gatt/gas.h | 25 +++++++ >> profiles/gatt/main.c | 52 ++++++++++++++ >> profiles/gatt/manager.c | 82 +++++++++++++++++++++ >> profiles/gatt/manager.h | 24 ++++++ >> src/dbus-common.c | 2 + >> src/device.c | 74 +++++-------------- >> src/device.h | 1 + >> 9 files changed, 390 insertions(+), 57 deletions(-) >> create mode 100644 profiles/gatt/gas.c >> create mode 100644 profiles/gatt/gas.h >> create mode 100644 profiles/gatt/main.c >> create mode 100644 profiles/gatt/manager.c >> create mode 100644 profiles/gatt/manager.h > > Besides the one comment I already sent about this patch set it looks > more or less ok to me. Would it also make sense to move the server-side > GAP functionality into this plugin? > > Johan Probably yes. If we don't find impediments we will send patches to move this code. BR, Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
