Hi,
On Thu, Aug 16, 2012, João Paulo Rechi Vita wrote:
> +void adapter_connect_list_add(struct btd_adapter *adapter,
> + struct btd_device *device)
> +{
> + if (g_slist_find(adapter->connect_list, device)) {
> + DBG("trying to add device %s which is already in the connect "
> + "list, ignoring", device_get_path(device));
> + return;
> + }
If possible could you try to avoid split message strings. Since the
context (function name, line number) is anyway logged with DBG you could
just have e.g. "ignoring already added device %s"
> + adapter->connect_list = g_slist_append(adapter->connect_list, device);
Looks like there's a missing btd_device_ref here.
> +void adapter_connect_list_remove(struct btd_adapter *adapter,
> + struct btd_device *device)
> +{
> + adapter->connect_list = g_slist_remove(adapter->connect_list, device);
And a missing btd_device_unref here.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
