Hi Mat, On Wed, Aug 15, 2012 at 09:56:04AM -0700, Mat Martineau wrote: ... > > > >I feel that this function is too big. Maybe we could split channel move > >and channel create operations? > > Sure, the "if (chan->state != BT_CONNECTED)" clause would be clearer > in a channel create function, and the other clauses can go in a > channel move function. Maybe we could define new state BT_MOVING ? Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html