Re: [PATCH BlueZ v0] gdbus: Fix compilation error if macro "error" is defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

--------------------------------------------------
From: "Lucas De Marchi" <lucas.demarchi@xxxxxxxxxxxxxx>
Sent: Monday, August 13, 2012 7:33 PM
To: "Jaganath Kanakkassery" <jaganath.k@xxxxxxxxxxx>
Cc: <linux-bluetooth@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH BlueZ v0] gdbus: Fix compilation error if macro "error" is defined

On Wed, Aug 1, 2012 at 7:26 AM, Jaganath Kanakkassery
<jaganath.k@xxxxxxxxxxx> wrote:
The variable "signature" used in error is not defined.
---
v0 -> Made error message as per Lucas's suggestion

 gdbus/object.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdbus/object.c b/gdbus/object.c
index 900e7ab..9689006 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -645,8 +645,8 @@ static dbus_bool_t emit_signal_valist(DBusConnection *conn,
                goto fail;

        if (g_dbus_args_have_signature(args, signal) == FALSE) {
-               error("%s.%s: expected signature'%s' but got '%s'",
-                               interface, name, args, signature);
+ error("%s.%s: got unexpected signature '%s'", interface, name, + dbus_message_get_signature(signal));
                ret = FALSE;
                goto fail;

Ack.

Lucas De Marchi
--

Ping.

Thanks,
Jaganath
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux