str2ba already checks if address is valid before converting and returns -1 in case of failure. --- plugins/dbusoob.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/dbusoob.c b/plugins/dbusoob.c index 1791342..d259159 100644 --- a/plugins/dbusoob.c +++ b/plugins/dbusoob.c @@ -164,11 +164,9 @@ static DBusMessage *remove_remote_data(DBusConnection *conn, DBusMessage *msg, DBUS_TYPE_INVALID)) return btd_error_invalid_args(msg); - if (bachk(addr)) + if (str2ba(addr, &bdaddr) < 0) return btd_error_invalid_args(msg); - str2ba(addr, &bdaddr); - if (btd_adapter_remove_remote_oob_data(adapter, &bdaddr)) return btd_error_failed(msg, "Request failed"); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html