Hi Marcel,
On Wed, Aug 8, 2012 at 3:52 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Mikel,
>
>> MGMT_EV_DEVICE_DISCONNECTED will now expose the disconnection reason to
>> userland, distinguishing four possible values:
>>
>> 0x00 Reason not known or unspecified
>> 0x01 ACL connection timeout
>> 0x02 ACL connection terminated by local host
>> 0x03 ACL connection terminated by remote host
>
> I think we need to leave ACL out here. Since that is not how we defined
> what a connection is in mgmt terms.
>
>> Note that the local/remote distinction just determines which side
>> terminated the low-level ACL connection, regardless of the disconnection
>> of the higher-level profiles.
>>
>> This can sometimes be misleading and thus must be used with care. For
>> example, some hardware combinations would report a locally initiated
>> disconnection even if the user turned Bluetooth off in the remote side.
>
> Please make sure that this comment makes it also into the API
> description.
I will send an updated version soon, with all your suggestions, along
with the updated userland patch where you can see the API
documentation.
<snip>
>> @@ -1906,12 +1907,29 @@ static void hci_disconn_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
>>
>> if (test_and_clear_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags) &&
>> (conn->type == ACL_LINK || conn->type == LE_LINK)) {
>> - if (ev->status != 0)
>> + if (ev->status != 0) {
>
> While at it, turn this into if (ev->status).
I will send a separate patch for this and other similar occurrences.
Let me know if you prefer to squash the change.
Cheers,
Mikel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
