Hi Mat, On Mon, Aug 06, 2012 at 09:33:50AM -0700, Mat Martineau wrote: > >>>>+ chan->move_cmd_ident = cmd->ident; > >>> > >>>BTW: Why do we handle ident in a special way for channel move? > >> > >>At the time I wrote the code, I thought that chan->ident was only > >>used to store idents of sent requests, not received requests. But > >>it does look like it is also used for storing received idents for > >>use in sending responses. chan->ident could be used as long as move > >>collisions are handled correctly (where a move request is received > >>when a move response is expected). > > > >So can we use chan->ident instead of chan->move_cmd_ident? Is the channel > >move somehow different from other L2CAP request / response sequence? > > Yes, chan->ident can be used. It doesn't seem necessary to assign > chan->ident when sending a move request, just when receiving one. > > Connect and create requests also assign chan->ident when they are > sent, but I'm not sure why. My understanding is that ident only used to match responses with requests. So channel move is not a special case. Reference: BLUETOOTH SPECIFICATION Version 4.0 [Vol 3] page 56 of 656 Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
