Re: [PATCH BlueZ V2 2/5] AVRCP: Rename variables used for control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vani,

On Fri, Aug 3, 2012 at 9:44 AM, Vani-dineshbhai PATEL
<vani.patel@xxxxxxxxxxxxxx> wrote:
> -       err = avctp_send_vendordep(player->session, player->transaction_events[id],
> +       err = avctp_send_vendordep(player->session,
> +                                       player->transaction_events[id],
>                                         AVC_CTYPE_CHANGED, AVC_SUBUNIT_PANEL,
>                                         buf, size + AVRCP_HEADER_LENGTH);

Git complain about this line, apparently you are leaving a whitespace:

Applying: AVRCP: Rename variables used for control
/home/vudentz/git/bluez/.git/rebase-apply/patch:390: trailing whitespace.
	err = avctp_send_vendordep(player->session,
fatal: 1 line adds whitespace errors.

>         if (err < 0)
> @@ -914,7 +915,7 @@ static uint8_t avrcp_handle_get_play_status(struct avrcp_player *player,
>
>         memcpy(&pdu->params[0], &duration, 4);
>         memcpy(&pdu->params[4], &position, 4);
> -       pdu->params[8] = player->cb->get_status(player->user_data);;
> +       pdu->params[8] = player->cb->get_status(player->user_data);

This one should be fixed in separate, it has nothing to do with other
changes you are introducing and could probably be applied very
quickly.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux