Hi Lucas,
--------------------------------------------------
From: "Lucas De Marchi" <lucas.demarchi@xxxxxxxxxxxxxx>
Sent: Friday, July 27, 2012 5:55 PM
To: "Jaganath Kanakkassery" <jaganath.k@xxxxxxxxxxx>
Cc: <linux-bluetooth@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH BlueZ] gdbus: Fix compilation error if macro "error" is
defined
On Fri, Jul 27, 2012 at 4:44 AM, Jaganath Kanakkassery
<jaganath.k@xxxxxxxxxxx> wrote:
The variable "signature" used in error is not defined.
---
gdbus/object.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 900e7ab..0f05234 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -645,8 +645,7 @@ static dbus_bool_t emit_signal_valist(DBusConnection
*conn,
goto fail;
if (g_dbus_args_have_signature(args, signal) == FALSE) {
- error("%s.%s: expected signature'%s' but got '%s'",
- interface, name, args, signature);
+ error("signature does not match");
argh... indeed.
However I'd rather fix it by letting a similar message (without args,
which have a different type):
error("%s.%s: got unexpected signature '%s'",
interface, name,
dbus_message_get_signature(signal));
Ok, I will raise patch.
Thanks,
Jaganath
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
