Hi Joao,
On Fri, Jul 27, 2012 at 6:29 PM, João Paulo Rechi Vita
<jprvita@xxxxxxxxxxxxx> wrote:
> If we fail to communicate with the MGMT socket is better to print the
> error message on the mgmtops plugin, where it really happened, instead
> of leaving this job to its users.
> ---
> src/adapter.c | 6 +-----
> src/mgmt.c | 7 +++++--
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index c9c82e3..5dd9821 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -997,13 +997,9 @@ struct btd_device *adapter_get_device(DBusConnection *conn,
> static gboolean discovery_cb(gpointer user_data)
> {
> struct btd_adapter *adapter = user_data;
> - int err;
>
> adapter->discov_id = 0;
> -
> - err = mgmt_start_discovery(adapter->dev_id);
> - if (err < 0)
> - error("start_discovery: %s (%d)", strerror(-err), -err);
> + mgmt_start_discovery(adapter->dev_id);
>
> return FALSE;
> }
> diff --git a/src/mgmt.c b/src/mgmt.c
> index c55b1a8..d73cf2a 100644
> --- a/src/mgmt.c
> +++ b/src/mgmt.c
> @@ -1961,8 +1961,11 @@ int mgmt_start_discovery(int index)
>
> cp->type = info->discov_type;
>
> - if (write(mgmt_sock, buf, sizeof(buf)) < 0)
> - return -errno;
> + if (write(mgmt_sock, buf, sizeof(buf)) < 0) {
> + int err = -errno;
> + error("failed to write to MGMT socket: %s", strerror(err));
I think this should be "strerror(-err)".
> + return err;
> + }
>
> return 0;
> }
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
