Hello Mikel,
On 27/07/2012 10:25, Mikel Astiz wrote:
-static void hfp_slc_complete(struct audio_device *dev)
+void headset_slc_complete(struct audio_device *dev)
Just to clarify: Is this a trivial rename being squashed in the same
patch? Or is there some reason behind?
This is used by telephony.c to inform headset.c that connection has been
completed for HSP or HFP.
It is no more specific to HFP.
{
struct headset *hs = dev->headset;
struct pending_connect *p = hs->pending;
- DBG("HFP Service Level Connection established");
+ DBG("Service Level Connection established");
Same here.
idem
<snip>
+gboolean telephony_get_ready_state(struct btd_adapter *adapter);
+uint32_t telephony_get_ag_features(void);
Shouldn't we start using uint16_t everywhere?
If not, the D-Bus agent should also support uint32_t, right?
Those 2 functions are removed in patch 8 "audio: Move HFP/HSP AG servers
to telephony.c".
So to avoid too many changes in headset.c I kept the previously used types.
Regards
Fred
--
Frederic Danis Open Source Technology Center
frederic.danis@xxxxxxxxx Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
