Hi Harald, On Wed, Jul 25, 2012 at 10:18 AM, Harald Schmitt <linux@xxxxxxxxxxx> wrote: > This one is related to that. But I think your proposal should be a > separate patch since it is about the incomming paths from an irmc > client. This one is more about to what irmc converts the incomming paths > to query phonebook-ebook and phonebook-tracker for contacts and call lists. > At the moment these well known paths in phonebook-*.c are designed to > match 1:1 with pbap spec and they are very similar to irmc, but there > could be a third implementation to query phonebook where this could be > different. While the backend indeed take an absolute path this doesnt mean we have to send as absolute path, not to mention it is not compatible with mimetypes which is what TYPE header describes, even in case of PBAP it is wrong to send absolute path in SETPATH. To avoid this problems we send relative although we do accept absolute, but to avoid problems with stack interpreting absolute path as not valid as OBEX spec state we always send relative paths. > The patch 1/2 fixes irmc to query phonebook implementation for the well > known absolute path. This was changed in pbap.c with the patch you > stated, but forgot to change in irmc.c. > Patch 2/2 just replaces the well-known phonebook paths which > phoenbook-ebook.c and phonebook-tracker.c support with constants. Im fine with converting to constants, it is more the sending of absolute path that Im not comfortable because of the potential interoperability problems it could cause. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
