Hi Oliver,
On Tue, Jul 24, 2012 at 03:31:37PM +0200, Oliver Neukum wrote:
> On Tuesday 24 July 2012 16:21:43 Andrei Emeltchenko wrote:
> > +void hci_queue_cb(struct hci_dev *hdev, struct hci_cb_cmd *cmd,
> > + struct workqueue_struct *workqueue)
> > +{
> > + struct hci_cb_work *work;
> > +
> > + BT_DBG("%s queue cmd %p", hdev->name, cmd);
> > +
> > + work = kmalloc(sizeof(*work), GFP_KERNEL);
>
> This looks like prone to deadlocks. You can run networked file
> systems over the link and allocating memory with GFP_KERNEL
> could run into a recursion problem.
Sorry, how this might run into recursion problem?
Best regards
Andrei Emeltchenko
>
> > + if (!work)
> > + return;
> > +
> > + INIT_WORK(&work->work, hci_cb_worker);
> > + work->hdev = hdev;
> > + work->cmd = cmd;
> > + hci_dev_hold(hdev);
> > +
> > + if (!queue_work(workqueue, &work->work)) {
> > + kfree(work);
> > + hci_dev_put(hdev);
> > + }
> > +}
>
> Regards
> Oliver
>
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
