Hi Luiz,
On Thu, Jul 19, 2012 at 7:49 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> This use sendmsg to send headers and operands in separated buffers
> avoiding memcpy.
> ---
Nice... only a small issue
> audio/avctp.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/audio/avctp.c b/audio/avctp.c
> index e3e5275..9ef6161 100644
> --- a/audio/avctp.c
> +++ b/audio/avctp.c
> @@ -929,23 +929,20 @@ static int avctp_send(struct avctp *session, uint8_t transaction, uint8_t cr,
> uint8_t code, uint8_t subunit, uint8_t opcode,
> uint8_t *operands, size_t operand_count)
> {
> - uint8_t *buf;
> + uint8_t buf[AVCTP_HEADER_LENGTH + AVC_HEADER_LENGTH];
you need to zero-out this, or set all the fields below.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
