Hi Johan, > -----Original Message----- > From: Johan Hedberg [mailto:johan.hedberg@xxxxxxxxx] > Sent: Wednesday, July 18, 2012 3:40 PM > To: Malovany, Ram > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] Bluetooth: Do not resolve name if entry was not > found. > > Hi Ram, > > On Wed, Jul 18, 2012, ramm@xxxxxx wrote: > > From: Ram Malovany <ramm@xxxxxx> > > > > If entry wasn't found in the hci_inquiry_cache_lookup_resolve do not > > resolve the name. > > > > Signed-off-by: Ram Malovany <ramm@xxxxxx> > > --- > > net/bluetooth/hci_event.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > I'm fine with all of these three patches but you might consider > improving the commit messages a bit. Especially with kernel patches it > doesn't hurt to have a bit more verbosity. > > Also, formulating the summary line as "Fix ..." would be good since they > *are* all fixes (this can help fast-tracking them upstream). It's > particularly important for this first one to be clearly identifiable as > a fix since it's fixing a NULL pointer dereference (something that > should also have been mentioned in the commit message imo). > > Another smaller cosmetic issue with the messages: usually the summary > lines do not end with a period. > Thanks for the remarks ,I will send an updates regarding the commit messages according to your comments. > Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
