Hi Mikel, On Wed, Jul 18, 2012, Mikel Astiz wrote: > On Mon, May 14, 2012 at 5:33 PM, Mikel Astiz <mikel.astiz.oss@xxxxxxxxx> wrote: > > From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> > > > > The error-handling code should use the defines instead of magic numbers. > > --- > > src/device.c | 42 +++++++++++++++++++++--------------------- > > 1 files changed, 21 insertions(+), 21 deletions(-) > > Ping. > > This was included inside a RFC series but has actually no dependency. Thanks for the reminder. The patch has now been applied. The usefulness of the patch is quite short-lived though since we've pretty much stopped using HCI related values in userspace with the introduction of mgmt. Looking at the code base it seems like several places need fixing as the status value passed from mgmt.c to core is not an HCI status but MGMT_STATUS_*. All places in the kernel should be converting HCI status values with mgmt_status() before putting them into a mgmt event. If you find some place that doesn't do that send a patch please. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
